merlimat commented on a change in pull request #10304:
URL: https://github.com/apache/pulsar/pull/10304#discussion_r617680396
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -337,6 +337,7 @@ public void close() throws PulsarServerException {
if (closeFuture != null) {
return closeFuture;
}
+ LOG.info("Closing");
Review comment:
We could use more explicit indication of what we're closing (and the
other logs here). I know the logger name will contain the class name, but just
to make it more clear and upfront.
```suggestion
LOG.info("Closing PulsarService");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
