lhotari commented on a change in pull request #10290:
URL: https://github.com/apache/pulsar/pull/10290#discussion_r618083732
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -711,7 +711,9 @@ private void setupInput(ContextImpl contextImpl) throws
Exception {
}.getType()), contextImpl);
}
} catch (Exception e) {
- log.error("Source open produced uncaught exception: ", e);
+ log.error("Source open produced uncaught exception with
ContextImpl of {}. "
+ + "sourceSpec is {}. Exception is {}.",
+ contextImpl.toString(), sourceSpec.toString(), e);
Review comment:
calling `.toString()` isn't necessary since the logger will do that when
you pass an object. There's another FAQ entry about that:
http://slf4j.org/faq.html#string_contents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
