lhotari opened a new pull request #10340:
URL: https://github.com/apache/pulsar/pull/10340


   ### Motivation
   
   "core-modules" profile is broken on JDK11
   
   ### Modifications
   
   - don't activate main profile based on JVM version
   
     - activating the main profile by default breaks the core-modules profile
       therefore a different solution is needed
   
     - when the jdk11-tests profile gets activated automatically, it breaks
       the default activation of the "main" profile. Therefore, it's necessary 
to add
       an explicit way to activate the main profile in the root pom.xml file.
   
   - Add explicit way to activate the main profile in the root pom.xml file. 
     - `-DmainModules` is used as the property activation
   
   - Update build scripts to include "-DmainModules" when there's no explicit 
profile and the intention is to start the "main" profile which gets activated 
on default on Java 8 (since the jdk11-tests profile doesn't block it from 
getting activated).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to