BewareMyPower commented on pull request #10330: URL: https://github.com/apache/pulsar/pull/10330#issuecomment-825694113
@codelipenghui Thanks for you help, I'll update the PR description after I changed the `beforeAddEntry` back. @eolivelli As what @codelipenghui mentioned, here we cannot avoid copying data because in BookKeeper side `CompositeByteBuf#nioBuffer` will be called. I think we can open an issue in https://github.com/apache/bookkeeper. So after BookKeeper side fixed the problem, we could change the code here to avoid copying data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
