merlimat commented on a change in pull request #10341:
URL: https://github.com/apache/pulsar/pull/10341#discussion_r619555247



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1015,12 +1015,12 @@ protected void handleSubscribe(final CommandSubscribe 
subscribe) {
                                                     "[{}][{}][{}] Failed to 
create consumer because exclusive consumer"
                                                             + " is already 
connected: {}",
                                                     remoteAddress, topicName, 
subscriptionName,
-                                                    
exception.getCause().getMessage());
+                                                    
exception.getCause().getMessage(), exception);
                                         }
                                     } else if (exception.getCause() instanceof 
BrokerServiceException) {
                                         log.warn("[{}][{}][{}] Failed to 
create consumer: consumerId={}, {}",
                                                  remoteAddress, topicName, 
subscriptionName,
-                                                 consumerId,  
exception.getCause().getMessage());
+                                                 consumerId,  
exception.getCause().getMessage(), exception);

Review comment:
       This was done on purpose to avoid stack traces for "known" or expected 
exceptions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to