congbobo184 commented on a change in pull request #10366:
URL: https://github.com/apache/pulsar/pull/10366#discussion_r619918617
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/TransactionMetadataStoreServiceTest.java
##########
@@ -181,6 +181,36 @@ public void testTimeoutTracker() throws Exception {
.until(() -> txnMap.size() == 0);
}
+ @Test
+ public void testTimeoutTrackerExpired() throws Exception {
+
pulsar.getTransactionMetadataStoreService().addTransactionMetadataStore(TransactionCoordinatorID.get(0));
+ Awaitility.await().atMost(2000, TimeUnit.MILLISECONDS)
+ .until(() -> pulsar.getTransactionMetadataStoreService()
+ .getStores().get(TransactionCoordinatorID.get(0)) !=
null);
+ MLTransactionMetadataStore transactionMetadataStore =
+ (MLTransactionMetadataStore)
pulsar.getTransactionMetadataStoreService()
+ .getStores().get(TransactionCoordinatorID.get(0));
+ checkTransactionMetadataStoreReady(transactionMetadataStore);
+ Field field =
MLTransactionMetadataStore.class.getDeclaredField("txnMetaMap");
+ field.setAccessible(true);
+ ConcurrentMap<TxnID, Pair<TxnMeta, List<Position>>> txnMap =
+ (ConcurrentMap<TxnID, Pair<TxnMeta, List<Position>>>)
field.get(transactionMetadataStore);
+
+ transactionMetadataStore.newTransaction(2000).get();
+
+ txnMap.forEach((txnID, txnMetaListPair) ->
+ Assert.assertEquals(txnMetaListPair.getLeft().status(),
TxnStatus.OPEN));
+ Awaitility.await().atLeast(1000, TimeUnit.MICROSECONDS).atMost(3000,
TimeUnit.MILLISECONDS)
+ .until(() -> txnMap.size() == 0);
+
+ transactionMetadataStore.newTransaction(2000).get();
+
+ txnMap.forEach((txnID, txnMetaListPair) ->
+ Assert.assertEquals(txnMetaListPair.getLeft().status(),
TxnStatus.OPEN));
+ Awaitility.await().atLeast(1000, TimeUnit.MICROSECONDS).atMost(3000,
TimeUnit.MILLISECONDS)
+ .until(() -> txnMap.size() == 0);
Review comment:
Regarding the timeout check, I think it can only be achieved by waiting.
any good idea do you have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
