tuteng commented on a change in pull request #10326:
URL: https://github.com/apache/pulsar/pull/10326#discussion_r619931462
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2316,10 +2329,10 @@ void internalTrimConsumedLedgers(CompletableFuture<?>
promise) {
log.debug("[{}] Ledger {} skipped for deletion as it is
currently being written to", name,
ls.getLedgerId());
break;
- } else if (expired) {
+ } else if (expired || isTruncate) {
log.debug("[{}] Ledger {} has expired, ts {}", name,
ls.getLedgerId(), ls.getTimestamp());
ledgersToDelete.add(ls);
- } else if (overRetentionQuota) {
+ } else if (overRetentionQuota || isTruncate) {
log.debug("[{}] Ledger {} is over quota", name,
ls.getLedgerId());
Review comment:
When overRetentionQuota is `false` and isTruncate is `true`, it seems
that the debug info needs to be updated.
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2316,10 +2329,10 @@ void internalTrimConsumedLedgers(CompletableFuture<?>
promise) {
log.debug("[{}] Ledger {} skipped for deletion as it is
currently being written to", name,
ls.getLedgerId());
break;
- } else if (expired) {
+ } else if (expired || isTruncate) {
log.debug("[{}] Ledger {} has expired, ts {}", name,
ls.getLedgerId(), ls.getTimestamp());
Review comment:
When expired is `false` and `isTruncate` is true, it seems that the
debug info needs to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
