merlimat commented on a change in pull request #10391:
URL: https://github.com/apache/pulsar/pull/10391#discussion_r623290256



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -401,29 +384,24 @@ private BundleData getBundleDataOrDefault(final String 
bundle) {
                 longTermData.setNumSamples(NUM_LONG_SAMPLES);
             }
         } catch (Exception e) {
-            log.warn("Error when trying to find bundle {} on zookeeper: {}", 
bundle, e);
+            log.warn("Error when trying to find bundle {} on metadata store: 
{}", bundle, e);

Review comment:
       `CompletableFuture.join()` doesn't actually have that in the signature, 
rather it's already wrapped




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to