merlimat commented on a change in pull request #10480:
URL: https://github.com/apache/pulsar/pull/10480#discussion_r625920033
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/RangeCache.java
##########
@@ -140,9 +140,11 @@ public Value get(Key key) {
continue;
}
- removedSize += weighter.getSize(value);
- value.release();
- ++removedEntries;
+ long entrySize = weighter.getSize(value);
Review comment:
eg: in case of concurrent invalidate, the value is already invalid here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
