sijie commented on a change in pull request #10487:
URL: https://github.com/apache/pulsar/pull/10487#discussion_r627000354



##########
File path: README.md
##########
@@ -93,32 +93,32 @@ Requirements:
 Compile and install:
 
 ```bash
-$ mvn install -DskipTests
+$ ./mvnw install -DskipTests

Review comment:
       How do people know to use `mvn.cmd`?
   
   If people use its local maven installation, `mvn install ...` works across 
different operating systems. 
   
   I am not against adding the mvn wrapper. But I don't think we should change 
the documentation. Once you change the documentation, you make people using 
windows hard to get started on building pulsar.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to