jerrypeng commented on a change in pull request #10491:
URL: https://github.com/apache/pulsar/pull/10491#discussion_r627921306
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PushPulsarSource.java
##########
@@ -75,4 +75,11 @@ public void consume(Record<T> record) {
public int getQueueLength() {
return DEFAULT_QUEUE_LENGTH;
}
+
+ /**
+ * Clear records that records are push onto
+ */
+ public void clear() {
Review comment:
This code change doesn't seem relevant to this PR
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -102,7 +102,7 @@ protected ConsumerBase(PulsarClientImpl client, String
topic, ConsumerConfigurat
this.incomingMessages = new GrowableArrayBlockingQueue<>();
this.unAckedChunkedMessageIdSequenceMap = new
ConcurrentOpenHashMap<>();
this.executorProvider = executorProvider;
- this.pinnedExecutor = (ScheduledExecutorService)
executorProvider.getExecutor();
+ this.pinnedExecutor = (ScheduledExecutorService)
executorProvider.getExecutor(conf.getSubscriptionName());
Review comment:
This code change doesn't seem relevant to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
