eolivelli commented on a change in pull request #10312:
URL: https://github.com/apache/pulsar/pull/10312#discussion_r628186341
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -2216,4 +2219,24 @@ public int
getBrokerDeleteInactiveTopicsMaxInactiveDurationSeconds() {
return brokerDeleteInactiveTopicsMaxInactiveDurationSeconds;
}
}
+
+ public String getAppliedAdvertisedAddress() {
Review comment:
I am fine with making this method "public", we must do it.
But I would like to suggest to the users that this method is a convenience
method, used by Pulsar Internals.
in fact this is not a plain property with getter/setter but it is computed.
if we add this method to this class, that is part of the Public API, then
users will be able to rely on it and if we want to change it we will have to
take into account backward compatibility.
I known that I am on the edge of nitpicking, but if we add a method to a
public, widely used API, we will have to maintain it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
