merlimat commented on a change in pull request #10513:
URL: https://github.com/apache/pulsar/pull/10513#discussion_r629838287
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -1397,9 +1399,14 @@ public OffloadProcessStatus offloadStatus(String topic)
WebTarget path = topicPath(tn, "offload");
final CompletableFuture<OffloadProcessStatus> future = new
CompletableFuture<>();
asyncGetRequest(path,
- new InvocationCallback<OffloadProcessStatus>() {
+ new InvocationCallback<String>() {
@Override
- public void completed(OffloadProcessStatus
offloadProcessStatus) {
+ public void completed(String jsonString) {
+ Gson gson = new
GsonBuilder().registerTypeAdapter(MessageId.class,
Review comment:
We should use Jackson for all the JSON ser/de, unless there's a
particular reason not to do so. Please use
`ObjectMapperFactory.getThreadLocal()....`
##########
File path: pulsar-io/kafka/pom.xml
##########
@@ -39,6 +39,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>pulsar-client-original</artifactId>
Review comment:
Why do we need pulsar client explicitly for Kafka connector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
