codelipenghui commented on a change in pull request #10600:
URL: https://github.com/apache/pulsar/pull/10600#discussion_r633198843
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -308,6 +324,32 @@ static void createTenantIfAbsent(ZooKeeper configStoreZk,
String tenant, String
}
}
+ static void createTenantIfAbsent(MetadataStore configStore, String tenant,
String cluster) throws IOException,
Review comment:
Does this method
https://github.com/apache/pulsar/pull/10600/files#diff-03a1201aab4aa284723e575a7c9b18ad9542fcc02beb80d83cfb87d64adf54b5R300
can be removed?
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -338,6 +380,32 @@ static void createNamespaceIfAbsent(ZooKeeper
configStoreZk, NamespaceName names
}
}
+ static void createNamespaceIfAbsent(MetadataStore configStore,
NamespaceName namespaceName, String cluster)
Review comment:
Can we delete this one?
https://github.com/apache/pulsar/pull/10600/files#diff-03a1201aab4aa284723e575a7c9b18ad9542fcc02beb80d83cfb87d64adf54b5R353
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java
##########
@@ -308,6 +324,32 @@ static void createTenantIfAbsent(ZooKeeper configStoreZk,
String tenant, String
}
}
+ static void createTenantIfAbsent(MetadataStore configStore, String tenant,
String cluster) throws IOException,
Review comment:
I see, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
