nlu90 commented on a change in pull request #10618:
URL: https://github.com/apache/pulsar/pull/10618#discussion_r634010528
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -318,28 +321,29 @@ private void setupStateStore() throws Exception {
}
}
- private void processResult(Record srcRecord,
- CompletableFuture<JavaExecutionResult> result)
throws Exception {
- result.whenComplete((result1, throwable) -> {
- if (throwable != null || result1.getUserException() != null) {
- Throwable t = throwable != null ? throwable :
result1.getUserException();
- log.warn("Encountered exception when processing message {}",
- srcRecord, t);
- stats.incrUserExceptions(t);
- srcRecord.fail();
+ private void processAsyncResults() throws InterruptedException {
Review comment:
no need for this empty method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
