eolivelli commented on a change in pull request #10604:
URL: https://github.com/apache/pulsar/pull/10604#discussion_r634082029
##########
File path:
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/generic/MultiVersionSchemaInfoProviderTest.java
##########
@@ -61,7 +62,7 @@ public void testGetSchema() throws Exception {
any(TopicName.class),
any(byte[].class)))
.thenReturn(completableFuture);
- SchemaInfo schemaInfoByVersion = schemaProvider.getSchemaByVersion(new
byte[0]).get();
+ SchemaInfo schemaInfoByVersion = schemaProvider.getSchemaByVersion(new
LongSchemaVersion(0).bytes()).get();
Review comment:
it looks like we are changing the behaviour.
can this be a problem ?
do we need to add some compatibility layer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
