vroyer commented on a change in pull request #10428:
URL: https://github.com/apache/pulsar/pull/10428#discussion_r636058935
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/util/SchemaUtil.java
##########
@@ -88,8 +90,10 @@ public static Schema extractAvroSchema(SchemaDefinition
schemaDefinition, Class
try {
return
parseAvroSchema(pojo.getDeclaredField("SCHEMA$").get(null).toString());
} catch (NoSuchFieldException | IllegalAccessException |
IllegalArgumentException ignored) {
- return schemaDefinition.getAlwaysAllowNull() ?
ReflectData.AllowNull.get().getSchema(pojo)
- : ReflectData.get().getSchema(pojo);
+ ReflectData reflectData = schemaDefinition.getAlwaysAllowNull() ?
ReflectData.AllowNull.get()
+ : ReflectData.get();
+ AvroSchema.addLogicalTypeConversions(reflectData,
schemaDefinition.isJsr310ConversionEnabled());
Review comment:
Yes, that is a potential issue, but you also have it with the
[AvroReader](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java#L49),
you can have several schemas sharing the same classloader. We can fix that by
creating a ReflectData instance each time rather than using the singleton
instance ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
