david-streamlio commented on a change in pull request #10593:
URL: https://github.com/apache/pulsar/pull/10593#discussion_r637028453
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSources.java
##########
@@ -315,6 +316,8 @@ protected void validateSourceConfigs(SourceConfig
sourceConfig) {
protected String DEPRECATED_sourceConfigString;
@Parameter(names = "--source-config", description = "Source config
key/values")
protected String sourceConfigString;
+ @Parameter(names = "--batch-source-config", description = "Batch
source config key/values")
+ protected String batchSourceConfigString;
Review comment:
@cckellogg If there was ever a new trigger type added to the project or
via a separate class by a user, then we would need to change this class to
perform the mapping from the "simple" name to the actual class name. I think it
is best to leave it as `--batch-source-config` to be consistent with the
`--source-config` switch that allows the user to send in all of the configs
inside a single JSON object.
I will add an example of a valid JSON object to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
