wolfstudy commented on a change in pull request #526:
URL: https://github.com/apache/pulsar-client-go/pull/526#discussion_r637672167
##########
File path: pulsar/impl_message.go
##########
@@ -112,6 +112,14 @@ func (id messageID) String() string {
return fmt.Sprintf("%d:%d:%d", id.ledgerID, id.entryID, id.partitionIdx)
}
+func (id messageID) Equals(other MessageID) bool {
+ rmsgid, ok := other.(messageID)
+ if !ok {
+ return false
+ }
+ return id.equal(rmsgid)
+}
+
Review comment:
The `MessageID` is an interface, Are we here trying to compare whether
two interfaces are equal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
