eolivelli commented on a change in pull request #10743:
URL: https://github.com/apache/pulsar/pull/10743#discussion_r641985311



##########
File path: 
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/KubernetesSecretsTokenAuthProvider.java
##########
@@ -97,14 +97,12 @@ public void configureAuthDataStatefulSet(V1StatefulSet 
statefulSet, Optional<Fun
                         .name(SECRET_NAME)
                         .secret(
                                 new V1SecretVolumeSource()
-                                        .secretName(getSecretName(new 
String(functionAuthData.get().getData())))
-                                        .defaultMode(256))));
+                                        .secretName(getSecretName(new 
String(functionAuthData.get().getData()))))));
 
         podSpec.getContainers().forEach(container -> 
container.setVolumeMounts(Collections.singletonList(
                 new V1VolumeMount()
                         .name(SECRET_NAME)
-                        .mountPath(DEFAULT_SECRET_MOUNT_DIR)
-                        .readOnly(true))));

Review comment:
       Why do we have to drop 'readonly' ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to