lhotari opened a new pull request #10764:
URL: https://github.com/apache/pulsar/pull/10764


   Fixes #10654
   
   ### Motivation
   
   See #10654 for more details.
   
   The javadoc of Prometheus client CollectorRegistry.getSampleValue method 
states:
   ["This is inefficient, and intended only for use in 
unittests."](https://github.com/prometheus/client_java/blob/8fcc7bc03dfbabd0c15776640d5fe52942aa9309/simpleclient/src/main/java/io/prometheus/client/CollectorRegistry.java#L261).
   
   ### Modifications
   
   - refactor DimensionStats to use a more efficient method where a snapshot of 
the metrics is created before
     individual quantile metric values are requested.
   - add a unit test case for DimensionStats to verify it's behavior


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to