eolivelli commented on a change in pull request #10811:
URL: https://github.com/apache/pulsar/pull/10811#discussion_r645054271
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoConsumeSchema.java
##########
@@ -308,13 +311,26 @@ public void fetchSchemaIfNeeded(SchemaVersion
schemaVersion) throws SchemaSerial
}
}
+ private SchemaVersion getSchemaVersion(byte[] schemaVersion) {
Review comment:
Probably not a big deal from a performance perspective.
But if a method does not use state from the instance it is better to mark it
'static'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
