[GitHub] [pulsar] Anonymitaet commented on pull request #10817: [docs] Incorrect use of subscription mode versus type

Tue, 08 Jun 2021 02:54:09 -0700 


Anonymitaet commented on pull request #10817:
URL: https://github.com/apache/pulsar/pull/10817#issuecomment-856631805


   Hi @codelipenghui 
   
   I searched `SubscriptionType` in the Pulsar repo, it refers to `Exclusive, 
Shared, Failover, Key_Shared`.
   
   
![image](https://user-images.githubusercontent.com/50226895/121163042-0aa73a00-c881-11eb-8b85-2679f2185b16.png)
   
   And I searched `SubscriptionMode` in the Pulsar repo, it refers to `Durable, 
NonDurable`.
   
![image](https://user-images.githubusercontent.com/50226895/121164272-0e878c00-c882-11eb-8a13-f9f8c1965f62.png)
   
   In this case, shall we change `mode` to `type` for `Exclusive, Shared, 
Failover, Key_Shared` in docs? Thanks.
   
![image](https://user-images.githubusercontent.com/50226895/121164905-750caa00-c882-11eb-94df-8d85334636ed.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to