nlu90 commented on pull request #10631: URL: https://github.com/apache/pulsar/pull/10631#issuecomment-858267166
> @nlu90 > > > Based on my understanding, these are pulsar cluster interaction methods that connectors may need. And actually, I'm planning to add one more interface getPulsarClient as a following PR to fix #8668 more concretely. > > 1. I think the goal and scope of this PR is refactor some of the code for various context interfaces so there is less duplicated code. Let's make the changes that are within that scope. Let's not try to do too many things in one PR. > 2. If we want to expose more of the interfaces of sources and sinks. Let's have a clear use case in mind before exposing additional interfaces. I am not in favor of just bulk adding additional interfaces for sources and sinks. I don't want to maintain functionality in sources and sinks that is not useful. For example, for a sink, is there a concrete use case in which a sink needs to publish a message to another pulsar topic? Sounds good to me. I'll limit the scope of this PR for only refactoring apis. Keep those listed apis only in the FunctionContext. And send additional PRs if apis are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
