BewareMyPower commented on pull request #10968: URL: https://github.com/apache/pulsar/pull/10968#issuecomment-863832357
I agree with @lhotari, the extra call of `skipBrokerEntryMetadataIfExist` should be removed. Regarding to the unit tests, I think the existed tests already cover the cases when broker entry metadata is not enabled. For the case that broker entry metadata is enabled, some tests have been added to `BrokerEntryMetadataE2ETest` that could also cover the case. IMO, you can only add tests to cover #10950 since this PR could solve the problem completely. /cc @wuzhanpeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
