eolivelli commented on a change in pull request #10963:
URL: https://github.com/apache/pulsar/pull/10963#discussion_r654284341
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/BrokerTestUtil.java
##########
@@ -29,4 +31,8 @@ public static String newUniqueName(String prefix) {
return prefix + "-" + UUID.randomUUID();
}
+ public static String randomSuffixString(String content, int numSuffix) {
+ return content + "-" +
RandomStringUtils.randomAlphabetic(numSuffix).toLowerCase();
Review comment:
why newUniqueName is not a good fit for you ?
##########
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -361,6 +361,42 @@
*/
CompletableFuture<Void> createPartitionedTopicAsync(String topic, int
numPartitions);
+ /**
+ * Create a partitioned topic.
+ * <p/>
+ * Create a partitioned topic. It needs to be called before creating a
producer for a partitioned topic.
+ * <p/>
+ *
+ * @param topic
+ * Topic name
+ * @param numPartitions
+ * Number of partitions to create of the topic
+ * @param createLocalTopicOnly
+ * False indicate create topic in all replicate clusters,
+ * true indicate only create topic in local cluster.
+ * @throws PulsarAdminException
+ */
+ void createPartitionedTopic(
Review comment:
this is a new public API for users.
I am not sure we should add this here.
it is fine to have it in the Implementation but we should not give this to
the users
@merlimat WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
