lhotari commented on a change in pull request #11027:
URL: https://github.com/apache/pulsar/pull/11027#discussion_r656756751
##########
File path:
pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/source/PulsarSourceTest.java
##########
@@ -54,7 +54,7 @@
import org.apache.pulsar.functions.api.Record;
import org.apache.pulsar.functions.api.SerDe;
import org.apache.pulsar.io.core.SourceContext;
-import org.junit.Assert;
+import org.testng.Assert;
Review comment:
Please check the order of arguments for assertEquals. In junit, the 1st
argument is the expected to value and 2nd is the actual value. In TestNG's
assertEquals the order is swapped. 1st argument is the actual value and 2nd is
the expected value. There the same difference in assertSame method.
There are a few usages of assertEquals and assertSame in this file. Please
fix the parameter order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
