congbobo184 commented on a change in pull request #11023:
URL: https://github.com/apache/pulsar/pull/11023#discussion_r656799878



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -955,7 +956,31 @@ private void resetSubscriptionCursor(Subscription 
subscription, CompletableFutur
     @Override
     public CompletableFuture<Void> unsubscribe(String subscriptionName) {
         CompletableFuture<Void> unsubscribeFuture = new CompletableFuture<>();
+        
getBrokerService().getManagedLedgerFactory().asyncDelete(TopicName.get(MLPendingAckStore

Review comment:
       if we enabled after disable, we will not have method to delete this, so 
we should every time delete `pendingAck`. I think we don't need to think about 
delete cursor speed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to