lbenc135 commented on a change in pull request #10981:
URL: https://github.com/apache/pulsar/pull/10981#discussion_r656822634
##########
File path: pulsar-client-cpp/python/src/config.cc
##########
@@ -110,61 +112,76 @@ class LoggerWrapper: public Logger {
public:
- LoggerWrapper(const std::string &logger, PyObject* pyLogger) {
+ LoggerWrapper(const std::string &filename, PyObject* pyLogger) {
_pyLogger = pyLogger;
Py_XINCREF(_pyLogger);
+ std::unique_ptr<LoggerFactory> factory(new ConsoleLoggerFactory());
+ fallbackLogger = factory->getLogger(filename);
+
_updateCurrentPythonLogLevel();
}
- LoggerWrapper(const LoggerWrapper& other) {
+ LoggerWrapper(LoggerWrapper& other) {
Review comment:
I removed the whole method to avoid bloating the code unnecessarily and
the potential memory leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
