eolivelli commented on a change in pull request #11062:
URL: https://github.com/apache/pulsar/pull/11062#discussion_r657652356
##########
File path:
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java
##########
@@ -183,9 +182,10 @@ public void testReacquireLeadershipAfterSessionLost()
throws Exception {
e = sessionEvents.poll(10, TimeUnit.SECONDS);
assertEquals(e, SessionEvent.SessionReestablished);
- Awaitility.await().untilAsserted(() -> {
- assertEquals(le1.getState(), LeaderElectionState.Leading);
- });
+ // due to zookeeper async notice, we need to wait.
+ Awaitility.await()
+ .until(() -> le1.getState() == LeaderElectionState.Leading);
+ assertEquals(le1.getState(), LeaderElectionState.Leading);
Review comment:
this line is redundant because we are waiting for this condition in the
Awaitility block
##########
File path:
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/ZKSessionTest.java
##########
@@ -171,10 +168,12 @@ public void testReacquireLeadershipAfterSessionLost()
throws Exception {
e = sessionEvents.poll(10, TimeUnit.SECONDS);
assertEquals(e, SessionEvent.SessionLost);
- Awaitility.await().untilAsserted(() -> {
- assertEquals(le1.getState(), LeaderElectionState.Leading);
- });
-
+ // due to zookeeper async notice, we need to wait.
+ Awaitility.await()
+ .until(() -> le1.getState() == LeaderElectionState.Leading);
+ assertEquals(le1.getState(), LeaderElectionState.Leading);
+ Awaitility.await()
+ .until(()-> leaderElectionEvents.poll() == null);
les = leaderElectionEvents.poll();
Review comment:
this assertion is redundant because we are waiting for the assertion to
be verified in the Awaitility loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
