wuchenxi123 opened a new pull request #11112:
URL: https://github.com/apache/pulsar/pull/11112
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the
pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull
request.
Skip *component* if you are unsure about which is the best component.
E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue:
#<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
1. Before Function is started, some resources only need to be initialized
once, and there is no need to make various judgments in the process() method of
the Function interface
2. After the Function is closed, in the process of using process(), the
referenced external resources need to be manually closed(), and they need to be
released separately in the close() of javaInstance
### Modifications
1. Before starting, some resources only need to be loaded once
2. When Function Instance manually releases some resources, users need to
implement the release method and provide support
@Slf4j
public class HelloWorldFunction implements Function<String, Void> {
@Override
public String process(byte[] input, Context context) {
}
}
eg:
@Slf4j
public class HelloWorldFunction implements Function<String, Void>,Hook {
@Override
public String process(byte[] input, Context context) {
}
/**
resource init
*/
@Override
public void preProcess(Context context) throws Exception {
database Connection
other resource initialize
}
/**
resource close
*/
@Override
public void postProcess() {
connection close
call the callback function
}
}
1. Provide an interface for initialization and unified release of external
resources for users to use, easy to manage and expand
2. The order of the release of external resources is controlled by the
pulsar function. Users only need to pay attention to the event processing
logic. The code is clearer and more concise, and the hierarchy is clear
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
yes
*(example:)*
- The initialization and release functions have been applied and verified
in the online project
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no) yes
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no) yes
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
