Anonymitaet commented on a change in pull request #11085:
URL: https://github.com/apache/pulsar/pull/11085#discussion_r659457592
##########
File path: site2/website/versioned_docs/version-2.8.1/client-libraries-java.md
##########
@@ -122,6 +122,9 @@ int|`connectionTimeoutMs`|Duration of waiting for a
connection to a broker to be
int|`requestTimeoutMs`|Maximum duration for completing a request |60000
int|`defaultBackoffIntervalNanos`| Default duration for a backoff interval |
TimeUnit.MILLISECONDS.toNanos(100);
long|`maxBackoffIntervalNanos`|Maximum duration for a backoff
interval|TimeUnit.SECONDS.toNanos(30)
+SocketAddress|`socks5ProxyAddress`|Socks5 proxy address | None
Review comment:
```suggestion
SocketAddress|`socks5ProxyAddress`|SOCKS5 proxy address | None
```
Please pay attention to the capitalization of the proper noun:
https://en.wikipedia.org/wiki/SOCKS
Please correct all occurrences, thanks.
##########
File path: site2/website/versioned_docs/version-2.8.1/client-libraries-java.md
##########
@@ -122,6 +122,9 @@ int|`connectionTimeoutMs`|Duration of waiting for a
connection to a broker to be
int|`requestTimeoutMs`|Maximum duration for completing a request |60000
int|`defaultBackoffIntervalNanos`| Default duration for a backoff interval |
TimeUnit.MILLISECONDS.toNanos(100);
long|`maxBackoffIntervalNanos`|Maximum duration for a backoff
interval|TimeUnit.SECONDS.toNanos(30)
+SocketAddress|`socks5ProxyAddress`|Socks5 proxy address | None
Review comment:
Do we need to add descriptions as below?
If you want to use the SOCKS5 proxy, you can add a SOCKS5 proxy handler in
the connection pool as the first handler for both producer and consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
