Technoboy- commented on a change in pull request #11085:
URL: https://github.com/apache/pulsar/pull/11085#discussion_r661213349
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -105,6 +109,11 @@
@JsonIgnore
private Clock clock = Clock.systemDefaultZone();
+ // socks5
+ private InetSocketAddress socks5ProxyAddress;
Review comment:
I just feel it's not accurate by string. If defined in String, mostly
have to parse(like System property).
BTW, it's the same definition with the Socks5ProxyHandler in Netty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
