MarvinCai opened a new pull request #11216:
URL: https://github.com/apache/pulsar/pull/11216
Fixes #5979
### Motivation
Support cumulative acknowledge for Websocket consumer.
### Modifications
For non-pull mode, use Admin API topics.getStats to calculate message
backlog difference before and after cumulative ack to properly track how many
message need to send to consumer. As individual ack will also change backlog
count, use a readwrite lock to prevent individual ack when doing cumulative ack.
For pull mode simply do cumulative ack.
### Verifying this change
This change added tests and can be verified as follows:
- *Added unit test to verify cumulative ack works.*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: yes
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
