freeznet commented on a change in pull request #11213: URL: https://github.com/apache/pulsar/pull/11213#discussion_r664212651
########## File path: site2/docs/helm-deploy.md ########## @@ -346,7 +346,7 @@ In this example, we name our Helm release `pulsar`. ```bash helm repo add apache https://pulsar.apache.org/charts helm repo update -helm upgrade --install pulsar apache/pulsar \ +helm install pulsar apache/pulsar \ --timeout 10m \ --set [your configuration options] Review comment: yes, but I think the initial idea of the note is, `helm upgrade --install` is suitable for both first time deployment and upgrade deployment, so according to the note, the user needs to set `--set initialize=true` to init the metadata if it is the first time deployment. With your change, `helm install` is always for the first time deployment, so I suggest adding `--set initialize=true` since it is not an optional config but a must-have one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
