nlu90 opened a new pull request #11251:
URL: https://github.com/apache/pulsar/pull/11251


   ### Motivation
   
   The Debezium requires pulsar a service URL for history database usage. 
   
   In #11056 , the `service.url` field from `PulsarKafkaWorkerConfig` is no 
longer available. And the value is also deleted from multiple yaml config files 
in this 
[commit](https://github.com/apache/pulsar/pull/11056/commits/3ce24c9e38c9420d60bfaf66aca92b78234082dc).
 This causes the integration test for Debezium connector to fail.
   
   Based on the Debezium 
[paradigm](https://debezium.io/documentation/reference/1.5/connectors/mysql.html#debezium-mysql-connector-database-history-configuration-properties),
 all configurations should be passed as strings. There's no easy way to inject 
a PulsarClient via configuration.
   
   We need to ask user to provide the pulsar url explicitly and probably auth 
info also.
   
   
   ### Modifications
   
   1. Make the `database.history.pulsar.service.url` field required
   2. Add the config value back to example yaml files
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to