eolivelli commented on a change in pull request #11304:
URL: https://github.com/apache/pulsar/pull/11304#discussion_r668798100
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java
##########
@@ -330,10 +275,35 @@ public void testTransactionBufferHandlerSemaphore()
throws Exception {
field.setAccessible(true);
field.set(transactionBufferHandler, new Semaphore(2));
- String topic = "persistent://" + namespace +
"/testTransactionBufferLookUp";
- tbClient.abortTxnOnSubscription(topic + "_abort_sub", "test", 1L, 1L,
-1L).get();
+
+ String topic = "persistent://" + namespace +
"/testTransactionBufferHandlerSemaphore";
+ String subName = "test";
+
+ admin.topics().createNonPartitionedTopic(topic + "_abort_sub");
+ admin.topics().createSubscription(topic + "_abort_sub", subName,
MessageId.earliest);
+
+ admin.topics().createNonPartitionedTopic(topic + "_commit_sub");
+ admin.topics().createSubscription(topic + "_commit_sub", subName,
MessageId.earliest);
+
+
+ Awaitility.await().until(() -> {
Review comment:
why do we have to retry this operation (and the `commit` below) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
