eolivelli commented on a change in pull request #11305:
URL: https://github.com/apache/pulsar/pull/11305#discussion_r668846109
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java
##########
@@ -311,10 +231,26 @@ public void testTransactionBufferChannelUnActive() {
}
@Test
- public void testTransactionBufferLookUp() throws ExecutionException,
InterruptedException {
+ public void testTransactionBufferLookUp() throws Exception {
String topic = "persistent://" + namespace +
"/testTransactionBufferLookUp";
- tbClient.abortTxnOnSubscription(topic + "_abort_sub", "test", 1L, 1L,
-1L).get();
- tbClient.commitTxnOnSubscription(topic + "_commit_sub", "test", 1L,
1L, -1L).get();
+
+ Awaitility.await().until(() -> {
Review comment:
can we explicitly wait for that initialisation ?
I have a question about how users are supposed to deal with this problem.
I know that TransactionBufferClient is an internal API.
but when we think about the user of "Transaction#commit" (and abort)...
does the PulsarClient wait automatically for this initialisation to complete
or will Transaction#commit fail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
