dlg99 commented on pull request #11251:
URL: https://github.com/apache/pulsar/pull/11251#issuecomment-879188175


   @sijie I second @eolivelli here. 
   We should either merge this change + fix for the CI or revert the breaking 
change, merge the fix for the CI, and do a follow up for the authentication 
after that.
   At least the follow up change will get tested this time.
   I don't find attractive idea of piling up more changes on top of this commit 
because it:
   - has unpredictable ETA. Whatever way you decide to go with authentication 
will require separate discussion/CR, maybe even PIP. 
   - is blocking other changes (i.e. debezium upgrade)
   - is leaving the debezium connectors in broken state (affects people 
testing/experimenting with pulsar on 2.9-snapshot)
   - assumes that more changes added with the integration tests not enabled on 
the CI
   
   We are dealing with a case of broken functionality in the build. I think the 
first priority should be fixing the regression quickly and new features should 
be second.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to