wolfstudy commented on a change in pull request #566:
URL: https://github.com/apache/pulsar-client-go/pull/566#discussion_r670099041



##########
File path: pulsar/internal/pulsartracing/producer_interceptor.go
##########
@@ -33,7 +33,9 @@ func (t *ProducerInterceptor) BeforeSend(producer 
pulsar.Producer, message *puls
        buildAndInjectSpan(message, producer).Finish()
 }
 
-func (t *ProducerInterceptor) OnSendAcknowledgement(producer pulsar.Producer, 
message *pulsar.ProducerMessage, msgID pulsar.MessageID) {
+func (t *ProducerInterceptor) OnSendAcknowledgement(producer pulsar.Producer,

Review comment:
       This will cause Action CI to fail:
   
   ```
   Error: pulsar/internal/pulsartracing/producer_interceptor.go:36: line is 136 
characters (lll)
   func (t *ProducerInterceptor) OnSendAcknowledgement(producer 
pulsar.Producer, message *pulsar.ProducerMessage, msgID pulsar.MessageID) {
   Error: pulsar/internal/pulsartracing/producer_interceptor_test.go:58: line 
is 132 characters (lll)
   func (p *mockProducer) SendAsync(context.Context, *pulsar.ProducerMessage, 
func(pulsar.MessageID, *pulsar.ProducerMessage, error)) {
   Error: Process completed with exit code 1.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to