equanz opened a new pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323


   ### Motivation
   
https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc
 causes some degraded behaviors at ZTSClient.
   
   1. when using boost::regex
      - can't set `path` at file scheme
   2. when using std::regex
      - can't set relative path like `file:./path/to/private.key`
   
   I'd like to fix this issue.
   
   ### Modifications
   
   * Use same regex code between boost and std like 
[this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38)
   * Fix regex to be able to capture relative path like `file:./`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - Add unit tests for `ZTSClientWrapper::parseUri` with relative path
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to