315157973 commented on a change in pull request #11316:
URL: https://github.com/apache/pulsar/pull/11316#discussion_r670523036
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
##########
@@ -302,10 +313,27 @@ private void
readMorePolicies(SystemTopicClient.Reader<PulsarEvent> reader) {
private void refreshTopicPoliciesCache(Message<PulsarEvent> msg) {
if (EventType.TOPIC_POLICY.equals(msg.getValue().getEventType())) {
TopicPoliciesEvent event = msg.getValue().getTopicPoliciesEvent();
- policiesCache.put(
- TopicName.get(event.getDomain(), event.getTenant(),
event.getNamespace(), event.getTopic()),
- event.getPolicies()
- );
+ TopicName topicName =
+ TopicName.get(event.getDomain(), event.getTenant(),
event.getNamespace(), event.getTopic());
+ switch (msg.getValue().getActionType()) {
+ case INSERT:
+ TopicPolicies old = policiesCache.putIfAbsent(topicName,
event.getPolicies());
+ if (old != null) {
+ log.warn("Policy insert failed, the topic: {}' policy
already exist", topicName);
+ }
+ break;
+ case UPDATE:
+ policiesCache.put(topicName, event.getPolicies());
+ break;
Review comment:
```
case INSERT:
case UPDATE:
TopicPolicies old = policiesCache.putIfAbsent(topicName,
event.getPolicies());
if (old != null) {
log.warn("Policy insert failed, the topic: {}' policy already
exist", topicName);
}
break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
