Anonymitaet commented on a change in pull request #11325:
URL: https://github.com/apache/pulsar/pull/11325#discussion_r670887824
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java
##########
@@ -310,6 +310,102 @@ public void
testBytesRateLimitingReceiveAllMessagesAfterThrottling(SubscriptionT
log.info("-- Exiting {} test --", methodName);
}
+ /**
+ * verify broker level rate-limiting should throttle message-dispatching
based on byte-rate
+ *
+ * <pre>
+ * 1. broker level dispatch-byte-rate = 1000 bytes/sec
+ * 2. start two consumers for two topics
+ * 3. send 15 msgs to each of the two topics: each msgs with 100 byte,
total 3000 byte
+ * 4. it should take up to 2 second to receive all messages of the two
topic
Review comment:
```suggestion
* 1. Broker level dispatch-byte-rate is equal to 1000 bytes per second.
* 2. Start two consumers for two topics.
* 3. Send 15 msgs to each of the two topics. Each msgs with 100 bytes,
thus 3000 bytes in total.
* 4. It should take up to 2 seconds to receive all messages of the two
topics.
```
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionMessageDispatchThrottlingTest.java
##########
@@ -310,6 +310,102 @@ public void
testBytesRateLimitingReceiveAllMessagesAfterThrottling(SubscriptionT
log.info("-- Exiting {} test --", methodName);
}
+ /**
+ * verify broker level rate-limiting should throttle message-dispatching
based on byte-rate
Review comment:
```suggestion
* Verify whether the broker level rate-limiting is throttle
message-dispatching based on byte-rate or not
```
do you mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
