eolivelli commented on a change in pull request #11263:
URL: https://github.com/apache/pulsar/pull/11263#discussion_r671131506
##########
File path:
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java
##########
@@ -0,0 +1,204 @@
+/**
Review comment:
@nlu90
Yes, this class may have some value and could be moved to utils/common.
But the ES Sink is a separate Pulsar IO Connector.
if we use a class from Pulsar `utils` or `commons` package it means that
that class is part of the Public API of Pulsar IO.
I believe that we could move this class to some shared public package in the
future, when we can see other users of it.
Does it make sense to you ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
