eolivelli commented on a change in pull request #11303:
URL: https://github.com/apache/pulsar/pull/11303#discussion_r672963134
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/CmdProduce.java
##########
@@ -114,6 +120,15 @@
@Parameter(names = { "-k", "--key"}, description = "message key to add ")
private String key;
+ @Parameter(names = { "-vs", "--value-schema"}, description = "Schema type
(can be bytes,avro,json,string...)")
+ private String valueSchema = "bytes";
+
+ @Parameter(names = { "-ks", "--key-schema"}, description = "Schema type
(can be bytes,avro,json,string...)")
+ private String keySchema = "string";
+
+ @Parameter(names = { "-kvet", "--key-value-encoding-type"}, description =
"Key Value Encoding Type (can be none,separated,inline)")
+ private String keyValueEncodingType = "none";
Review comment:
makes sense to me.
I have removed that value.
now if you do not pass explicitly this parameter we preserve the original
behaviour, otherwise we use KeyValueEncoding.
I am not adding the part about encoding the "key" with the schema because it
is not possible in Pulsar to set the schema for the key without KeyValueSchema.
I leave that as a future enhancement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
