eolivelli commented on a change in pull request #11389:
URL: https://github.com/apache/pulsar/pull/11389#discussion_r673075978
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -151,7 +151,7 @@
protected Map<String, String> propertiesMap;
protected final MetaStore store;
- private final ConcurrentLongHashMap<CompletableFuture<ReadHandle>>
ledgerCache = new ConcurrentLongHashMap<>(
+ protected final ConcurrentLongHashMap<CompletableFuture<ReadHandle>>
ledgerCache = new ConcurrentLongHashMap<>(
Review comment:
we can make it "package protected" in order to reduce visibility
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2410,7 +2410,7 @@ void internalTrimLedgers(boolean isTruncate,
CompletableFuture<?> promise) {
if (log.isDebugEnabled()) {
log.debug("[{}] Ledger {} not deleted. Neither expired
nor over-quota", name, ls.getLedgerId());
}
- break;
Review comment:
why are we removing this `break` ? this way the loop will continue to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
