devinbost commented on pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#issuecomment-885124392
I agree that we want to avoid the additional disk costs of having a directory for each function instance if it means a copy of the jar would be saved for every function instance. That would introduce scaling issues on clusters that have high function parallelism, and it would be a significant behavioral change for operations since many teams might not anticipate such a change in disk utilization and may not have enough disk allocated for the upgrade. -- Devin G. Bost On Thu, Jul 22, 2021, 4:50 AM Enrico Olivelli ***@***.***> wrote: > @jerrypeng <https://github.com/jerrypeng> @sijie > <https://github.com/sijie> @freeznet <https://github.com/freeznet> > IMHO I believe that if this patch is solving one problem and this is not > adding regressions or potentials problems in production it is fine to > commit it. > we could add more enhancements in the future if you have some additional > case that is still not covered by this fix. > > This patch adds unit tests that will fail without this patch > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pulsar/pull/11343#issuecomment-884820666>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABYTBL6VOHZYUX3B6JHPSWLTY7ZY5ANCNFSM5APZSMLA> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
