lhotari commented on a change in pull request #11372:
URL: https://github.com/apache/pulsar/pull/11372#discussion_r675639916
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java
##########
@@ -203,7 +203,7 @@ public synchronized boolean tryAcquire(long acquirePermit) {
*
* @return returns 0 if permits is not available
*/
- public synchronized long getAvailablePermits() {
+ public long getAvailablePermits() {
Review comment:
it's not damaging, but it's not needed for this fix. It's better to keep
the fix for the actual problem minimal and propose a separate change for
improving the design and implementation of RateLimiter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
