sanjivr opened a new pull request #11447:
URL: https://github.com/apache/pulsar/pull/11447


   ### Motivation
   
   The Reader API in the python client does not support reading an encrypted 
message. 
   This PR adds the same and leverages existing  C++ Reader API which supports 
the same.
   
   ### Modifications
   
   * Updated `pulsar.Client.create_reader` to accept  `crypto_key_reader` 
argument
   * Update existing unit test for Python encryption.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows: 
   
     - **Modified existing PulsarTest.test_encryption to also use a reader**
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: **Yes**
       - This is a backward compatible update to the signature of a [public 
method](https://pulsar.apache.org/api/python/2.8.0-SNAPSHOT/#pulsar.Client.create_reader)
 in Pulsar Python Client API
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   #### For contributor
   
   For this PR, do we need to update docs?
   
   **No. These updates will be picked up automatically by pdoc as described at 
https://pulsar.apache.org/docs/en/client-libraries-python/**  
   
   #### For committer
   
   For this PR, do we need to update docs?
   
   - If yes,
     
     - if you update docs in this PR, label this PR with the `doc` label.
     
     - if you plan to update docs later, label this PR with the `doc-required` 
label.
   
     - if you need help on updating docs, create a follow-up issue with the 
`doc-required` label.
     
   - If no, label this PR with the `no-need-doc` label and explain why.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to