315157973 commented on a change in pull request #11441:
URL: https://github.com/apache/pulsar/pull/11441#discussion_r679615152
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -64,6 +64,7 @@
private ByteBuf payload;
private Schema<T> schema;
+ private SchemaInfo schemaInfo;
Review comment:
We already have a schema, but we added a schemaInfo, which will make
other developers very confused. If we can't reuse existing attributes, we can
at least do this:
1) Make the new properties easier to understand, such as: naming
modification, or adding comments, so that other developers can know schemaInfo
only for replicator
2) Independent get/set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
